linux-kernel - Re: [PATCH 03/17] tools lib traceevent: Get rid of malloc_or_die() in trace_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140114210546.5bb3c85c@gandalf.local.home>
Date:	Tue, 14 Jan 2014 21:05:46 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH 03/17] tools lib traceevent: Get rid of malloc_or_die()
 in trace_seq_init()

On Wed, 15 Jan 2014 10:45:26 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> Use plain malloc() and check its return value.
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> ---
>  tools/lib/traceevent/trace-seq.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/lib/traceevent/trace-seq.c b/tools/lib/traceevent/trace-seq.c
> index 941d35d2cf87..339a0ffa21d5 100644
> --- a/tools/lib/traceevent/trace-seq.c
> +++ b/tools/lib/traceevent/trace-seq.c
> @@ -47,8 +47,11 @@ void trace_seq_init(struct trace_seq *s)
>  	s->len = 0;
>  	s->readpos = 0;
>  	s->buffer_size = TRACE_SEQ_BUF_SIZE;
> -	s->buffer = malloc_or_die(s->buffer_size);
> -	s->state = TRACE_SEQ__GOOD;
> +	s->buffer = malloc(s->buffer_size);
> +	if (s->buffer != NULL)
> +		s->state = TRACE_SEQ__GOOD;
> +	else
> +		s->state = TRACE_SEQ__MEM_ALLOC_FAILED;
>  }
>  
>  /**

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/