linux-kernel - Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140116030343.GF3807@dhcp-16-126.nay.redhat.com>
Date:	Thu, 16 Jan 2014 11:03:43 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
	Linux EFI <linux-efi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <bp@...e.de>,
	Matt Fleming <matt@...sole-pimps.org>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Toshi Kani <toshi.kani@...com>
Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an
 arbitrary pagetable

On 01/15/14 at 06:41pm, Arjan van de Ven wrote:
> On 1/15/2014 5:44 PM, Dave Young wrote:
> >On 01/15/14 at 06:11am, H. Peter Anvin wrote:
> >>On 01/14/2014 05:16 PM, Dave Young wrote:
> >>>>
> >>>>Why the [Finnish] do you feel that information needs to be in a
> >>>>different form because it is (currently!) not available as a module?
> >>>
> >>>I think moving them to comment can avoid including extra linux/module.h
> >>>
> >>
> >>And that matters, why?
> >
> >At least the code will be cleaner and kernel size will be a bit smaller?
> >
> 
> making something harder to grep and less standardized is hardly cleaner
> and these things compile to nothing for non-modules.

It's not nothing, just very small increasement:
   text	   data	    bss	    dec	    hex	filename
7636121	1391824	9355264	18383209	1188169	vmlinux

   text	   data	    bss	    dec	    hex	filename
7636113	1391824	9355264	18383201	1188161	vmlinux

I do not want to insist on this minor problem, if you want please keep it.

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/