lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jan 2014 15:20:57 +0900 From: HATAYAMA Daisuke <d.hatayama@...fujitsu.com> To: "H. Peter Anvin" <hpa@...or.com> CC: mingo@...nel.org, hpa@...ux.intel.com, linux-kernel@...r.kernel.org, tglx@...utronix.de, linux-tip-commits@...r.kernel.org Subject: Re: [tip:x86/apic] x86, apic: Make disabled_cpu_apicid static read_mostly, fix typos (2014/01/16 14:53), H. Peter Anvin wrote: > On 01/15/2014 08:44 PM, HATAYAMA Daisuke wrote: >> >> This is not typo in my intention. >> >> generic_processor_info() has two more cases where it ignores cpus. >> In either cases, printed messages are tagged with "ACPI" because this >> function is called when parsing ACPI MADT table in acpi_boot_init(); >> this function is also being used to parse other kind of tables but >> the "ACPI" tag would mean that the function was first for ACPI only. >> > > But it has nothing to do with ACPI -- it is an APIC ID from the command > line -- so that would be actively misleading. > > -hpa > I never disagree to the fix itself. I wanted to explain why I wrote so. I thought it was better to unify tags in the same function because they should bleong to the same component, here I mean ACPI, but it's better to avoid the confusion, which is bigger impact. -- Thanks. HATAYAMA, Daisuke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists