linux-kernel - Re: [PATCH/RFC] perf ui/tui: Show column header in hist browser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ppns92q8.fsf@sejong.aot.lge.com>
Date:	Thu, 16 Jan 2014 09:42:23 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH/RFC] perf ui/tui: Show column header in hist browser

Hi Arnaldo and Jiri,

On Wed, 15 Jan 2014 11:13:14 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jan 15, 2014 at 01:10:44PM +0100, Jiri Olsa escreveu:
>> On Wed, Jan 15, 2014 at 02:08:45PM +0900, Namhyung Kim wrote:
>> > Add a line for showing column headers like --stdio.
>> 
>> https://git.kernel.org/cgit/linux/kernel/git/jolsa/perf.git/commit/?h=perf/lock12&id=1a06d77629cb8870838132688f443b9ca1436026
>> 
>> ;-) I'll check your change
>
> From a quick view, your change looks better, i.e. being able to toggle
> the header line.
>
> Please let me know what you guys end up agreeing is best.

Yes, looking at the source, Jiri's version looks much better.  I was
lazy for sorting column width and supporting a hotkey for toggling. :)
I just wanted to see how you guys think, so the rfc.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/