linux-kernel - Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140116094200.GA16328@aepfle.de>
Date:	Thu, 16 Jan 2014 10:42:01 +0100
From:	Olaf Hering <olaf@...fle.de>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, apw@...onical.com,
	jasowang@...hat.com
Subject: Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

On Tue, Jan 14, K. Y. Srinivasan wrote:

> +enum hv_fcopy_op {
> +	START_FILE_COPY = 0,
> +	WRITE_TO_FILE,
> +	COMPLETE_FCOPY,
> +	CANCEL_FCOPY,
> +};
> +
> +struct hv_fcopy_hdr {
> +	enum hv_fcopy_op operation;
> +	uuid_le service_id0; /* currently unused */
> +	uuid_le service_id1; /* currently unused */
> +} __attribute__((packed));

Is enum a fixed size? This struct is used in other structs, so I wonder
what will happen to the kernel/user protocol if any of that changes. Or
with a 64bit kernel and 32bit daemon. Maybe operation should be __u32?


Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/