linux-kernel - Re: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jan 2014 12:02:48 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Jingchang Lu <b35083@...escale.com>
Cc:	vinod.koul@...el.com, dan.j.williams@...el.com,
	shawn.guo@...aro.org, pawel.moll@....com, mark.rutland@....com,
	swarren@...dotorg.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	Alison Wang <b18965@...escale.com>
Subject: Re: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support

On Thursday 16 January 2014, Jingchang Lu wrote:
> Add Freescale enhanced direct memory(eDMA) controller support.
> This module can be found on Vybrid and LS-1 SoCs.
> 
> Signed-off-by: Alison Wang <b18965@...escale.com>
> Signed-off-by: Jingchang Lu <b35083@...escale.com>

Very nice! All my previous comments have been addressed, so

Acked-by: Arnd Bergmann <arnd@...db.de>

One small comment still:

> +
> +static DEFINE_MUTEX(fsl_edma_mutex);
> +

I think this mutex should be part of struct fsl_edma_engine, not global.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/