linux-kernel - Re: [PATCHv3 7/8] zram: drop not used table `count' member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140116141722.GA2176@swordfish.minsk.epam.com>
Date:	Thu, 16 Jan 2014 17:17:22 +0300
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Jerome Marchand <jmarchan@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan@...nel.org>,
	Nitin Gupta <ngupta@...are.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 7/8] zram: drop not used table `count' member

On (01/16/14 14:52), Jerome Marchand wrote:
> On 01/16/2014 02:12 PM, Sergey Senozhatsky wrote:
> > struct table `count' member is not used.
> 
> What was the intended use of this counter anyway?
> 
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > ---
> >  drivers/block/zram/zram_drv.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> > index 58d4ac5..1d5b1f5 100644
> > --- a/drivers/block/zram/zram_drv.h
> > +++ b/drivers/block/zram/zram_drv.h
> > @@ -64,7 +64,6 @@ enum zram_pageflags {
> >  struct table {
> >  	unsigned long handle;
> >  	u16 size;	/* object size (excluding header) */
> > -	u8 count;	/* object ref count (not yet used) */
> >  	u8 flags;
> 
>

> I noticed that your earlier version of this patch changed the
> flags size to 16. What has changed?
> 

nothing really. I was going to extend flags, but changed my plans. so it was
a leftover.

	-ss

> Jerome
> 
> >  } __aligned(4);
> >  
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/