lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jan 2014 11:48:33 -0500 From: Jason Cooper <jason@...edaemon.net> To: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, Russell King <linux@....linux.org.uk>, linux-kernel@...r.kernel.org, Ian Campbell <ijc@...lion.org.uk>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] ARM: orion: provide C-style interrupt handler for MULTI_IRQ_HANDLER Sebastian, On Thu, Jan 16, 2014 at 09:10:31AM +0100, Sebastian Hesselbarth wrote: > DT-enabled Marvell Kirkwood and Dove SoCs make use of an irqchip > driver. As expected for irqchip drivers, it uses a C-style > interrupt handler and therefore selects MULTI_IRQ_HANDLER. > > Now, compiling a kernel with both non-DT and DT support enabled, > selecting MULTI_IRQ_HANDLER will break ASM irq handler used by > non-DT boards. > > Therefore, we provide a C-style irq handler even for non-DT boards, > if MULTI_IRQ_HANDLER is set. By installing the C-style irq handler > in orion_irq_init this is transparent to all non-DT board files. > > While the regression report was filed on Marvell Kirkwood, also > Marvell Dove non-DT boards are affected and fixed by this patch. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> > Tested-by: Ian Campbell <ijc@...lion.org.uk> > Reported-by: Ian Campbell <ijc@...lion.org.uk> > Fixes: 2326f04321a9 ("ARM: kirkwood: convert to DT irqchip and clocksource") > Fixes: f07d73e33d0e ("ARM: dove: convert to DT irqchip and clocksource") > --- > Compared to the two patch version sent on Ian's regression report, > I cooked this down to a single patch only touching plat-orion/irq.c. > I also dropped Orion5x and MV78x00, as they not yet select MULTI_IRQ_HANDLER > at all. Instead I added a comment about taking care of them, as soon as > they move over to an irqchip driver themselves. > > I have not yet Cc'ed this patch to -stable to get some discussion and > an Acked-by from Jason or Andrew, too. > > Cc: Jason Cooper <jason@...edaemon.net> > Cc: Andrew Lunn <andrew@...n.ch> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> > Cc: Russell King <linux@....linux.org.uk> > Cc: Ian Campbell <ijc@...lion.org.uk> > Cc: linux-arm-kernel@...ts.infradead.org > Cc: linux-kernel@...r.kernel.org > --- > arch/arm/plat-orion/irq.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) Applied to mvebu/fixes with Andrew's Ack. It's too late for v3.13, so it'll be the first thing sent for v3.14. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists