linux-kernel - Re: [PATCH v2 1/2] net/mlx4_core: clean up cq_res_start_move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140116.113947.1353295150580987909.davem@davemloft.net>
Date:	Thu, 16 Jan 2014 11:39:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jackm@....mellanox.co.il
Cc:	pebolle@...cali.nl, ogerlitz@...lanox.com, ronye@...lanox.com,
	hadarh@...lanox.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] net/mlx4_core: clean up cq_res_start_move_to()

From: Jack Morgenstein <jackm@....mellanox.co.il>
Date: Thu, 16 Jan 2014 09:46:39 +0200

> ACK.  OK.

This is not the correct way to ack a patch.

First of all, you should not top post.  Instead you should quote
the relevant parts of the email you are replying to, and then add
your new content underneath.

In this circumstance, the "relevant parts" are just the commit log
message from the patch submitter.  There is no reason ever to quote
the patch itself unless you are making comments on specific parts.

And you specify your ACK using a properly formed "Acked-by: "
line.

Please look at how other reviewers ACK patches.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/