linux-kernel - Re: [PATCH] sh: kgdb: Add missing #include <linux/sched.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jan 2014 23:28:21 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Wanlong Gao <gaowanlong@...fujitsu.com>,
	Geert Uytterhoeven <geert+renesas@...ux-m68k.org>
Subject: Re: [PATCH] sh: kgdb: Add missing #include <linux/sched.h>

On Thu, Jan 16, 2014 at 11:24 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Thu, Jan 16, 2014 at 11:20:00PM +0100, Geert Uytterhoeven wrote:
>> From: Wanlong Gao <gaowanlong@...fujitsu.com>
>>
>> arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
>> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
>> arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
>> arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
>> arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
>> ("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
>
> Which showed up in 3.9-rc1, seems that no one seems to care about this
> arch/config much :)

That's why I didn't dare to add a CC to stable myself ;-)

BTW, the patch is also a few months old.

>> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
>> Signed-off-by: Wanlong Gao <gaowanlong@...fujitsu.com>
>> [geert: Reworded and reformatted]
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...ux-m68k.org>
>
> Cc: stable <stable@...r.kernel.org>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/