linux-kernel - Re: [PATCH v2 3/5] intel-iommu: integrate DMA CMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyhtr+BXN7dWh3A5QZcMKhHshpt9bzRF_Tce12tu4TMntg@mail.gmail.com>
Date:	Fri, 17 Jan 2014 08:28:53 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Don Dutile <ddutile@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <andi@...stfloor.org>,
	x86@...nel.org, iommu@...ts.linux-foundation.org
Subject: Re: [PATCH v2 3/5] intel-iommu: integrate DMA CMA

2014/1/16 Marek Szyprowski <m.szyprowski@...sung.com>:
>> @@ -3019,17 +3019,31 @@ static void *intel_alloc_coherent(struct device
>> *hwdev, size_t size,
>>                         flags |= GFP_DMA32;
>>         }
>>   -     vaddr = (void *)__get_free_pages(flags, order);
>> -       if (!vaddr)
>> +       if (!(flags & GFP_ATOMIC)) {
>
>
> GFP_ATOMIC is not a flag, so please change the above check to:
>            if (flags & __GFP_WAIT)

Thanks for your review.  I'll fix it in the next version.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/