lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jan 2014 16:35:31 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Christopher Heiny <cheiny@...aptics.com> Cc: Andrew Duggan <aduggan@...aptics.com>, Vincent Huang <vincent.huang@...synaptics.com>, Vivian Ly <vly@...aptics.com>, Daniel Rosenberg <daniel.rosenberg@...aptics.com>, Linus Walleij <linus.walleij@...ricsson.com>, Benjamin Tissoires <benjamin.tissoires@...hat.com>, Linux Input <linux-input@...r.kernel.org>, Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 4/4] Input: synaptics-rmi4 - switch to using i2c_transfer() On Tue, Jan 14, 2014 at 12:26:47AM -0800, Christopher Heiny wrote: > On 01/09/2014 11:44 PM, Dmitry Torokhov wrote: > > > >- dev_dbg(&client->dev, "writes 1 bytes: %02x\n", txbuf[0]); > >+ retval = i2c_transfer(client->adapter, msgs, sizeof(msgs)); > >+ if (retval == sizeof(msgs)) > > I think this should be: > retval = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)); > if (retval == ARRAY_SIZE(msgs)) > At least, that change resolved some random misbehaviors, including > kernel panics. You are absolutely right, I just committed a fix for that. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists