linux-kernel - Re: [ipc] 5769cf63: LTP semget02 TFAILs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140118000830.6df3531aaaf85fc284313b13@canb.auug.org.au>
Date:	Sat, 18 Jan 2014 00:08:30 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Davidlohr Bueso <davidlohr@...com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [ipc] 5769cf63: LTP semget02 TFAILs

[ Just adding Andrew to the cc list ]

On Fri, 17 Jan 2014 18:24:28 +0800 Fengguang Wu <fengguang.wu@...el.com> wrote:
>
> Hi Davidlohr,
> 
> We noticed LTP test failures
> 
>         ltp.msgget02.1.TFAIL
>         ltp.semget02.2.TFAIL
>         ltp.semget02.3.TFAIL
> 
> and the first bad commit is
> 
> commit 5769cf6355d87f63906b3e51887eff7017c39217
> Author:     Davidlohr Bueso <davidlohr@...com>
> AuthorDate: Wed Jan 15 16:56:01 2014 +1100
> Commit:     Stephen Rothwell <sfr@...b.auug.org.au>
> CommitDate: Wed Jan 15 16:56:01 2014 +1100
> 
>     ipc: share ids rwsem when possible in ipcget_public
>     
>     ...  and rewrite the function.  For scenarios where the key is found and
>     we end up just doing different routinary checks, we can downgrade the
>     ids->rwsem and share it among concurrent readers.  These checks include
>     the following, which are all safe to share the lock:
>     
>     ops->more_checks() >>  sem_more_checks(), shm_more_checks()
>     ipc_check_perms()  >>  ipcperms(),ops->associate() >> [lsm]_[ipctype]_associate()
>     
>     Signed-off-by: Davidlohr Bueso <davidlohr@...com>
>     Cc: Aswin Chandramouleeswaran <aswin@...com>
>     Cc: Rik van Riel <riel@...hat.com>
>     Cc: Manfred Spraul <manfred@...orfullife.com>
>     Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> 
>  ipc/util.c | 60 +++++++++++++++++++++++++++++++++---------------------------
>  1 file changed, 33 insertions(+), 27 deletions(-)
> 
> Thanks,
> Fengguang
> 


-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped