linux-kernel - Re: [PATCHv2 3/3] Input: edt-ft5x06: Add DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52D88B6E.6010709@kernelconcepts.de>
Date:	Fri, 17 Jan 2014 02:46:22 +0100
From:	Simon Budig <simon.budig@...nelconcepts.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Lothar Waßmann <LW@...O-electronics.de>,
	linux-input@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>,
	Thierry Reding <thierry.reding@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Silvio F <silvio.fricke@...il.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Jingoo Han <jg1.han@...sung.com>,
	Fugang Duan <B38611@...escale.com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 3/3] Input: edt-ft5x06: Add DT support

Hi Dmitry

On 17/01/14 01:26, Dmitry Torokhov wrote:
>> +  The following properties provide default values for the
>> +  corresponding parameters (see Documentation/input/edt-ft5x06.txt)
>> +- edt,threshold: allows setting the "click"-threshold in the range from 20 to 80.
>> +- edt,gain: sensitivity (0..31) (lower value -> higher sensitivity)
>> +- edt,offset: edge compensation (0..31)
>> +- edt,report-rate: report rate (3..14)
> 
> I wonder if we really need to have it in device tree? Can users needing
> top tweak the settings do it via udev rules?

IMO it makes sense to have these in the device tree. These values need
to be adjusted if you have glass or acrylics in front of the touch
glass. The defaults are tailored to the touchscreen without any
(additional) material in front of it.

So manufacturers need to provide different defaults depending on the way
a specific device is built. So these properties can be viewed in the
same way you specify display resolution or display type in the device tree.

Bye,
         Simon


-- 
       Simon Budig                        kernel concepts GmbH
       simon.budig@...nelconcepts.de      Sieghuetter Hauptweg 48
       +49-271-771091-17                  D-57072 Siegen



Download attachment "signature.asc" of type "application/pgp-signature" (243 bytes)