linux-kernel - Re: [PATCH] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 19 Jan 2014 20:37:49 +0100
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Prabhakar Lad <prabhakar.csengg@...il.com>
Cc:	LMML <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

Hi Prabhakar,

Thank you for the patch.

On Friday 17 January 2014 14:47:33 Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> 
> clk_set_rate(), clk_prepare_enable() functions can fail, so check the return
> values to avoid surprises.
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> ---
>  drivers/media/i2c/mt9p031.c |   12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> index e5ddf47..dbe34d7 100644
> --- a/drivers/media/i2c/mt9p031.c
> +++ b/drivers/media/i2c/mt9p031.c
> @@ -222,12 +222,15 @@ static int mt9p031_clk_setup(struct mt9p031 *mt9p031)
> 
>  	struct i2c_client *client = v4l2_get_subdevdata(&mt9p031->subdev);
>  	struct mt9p031_platform_data *pdata = mt9p031->pdata;
> +	int ret;
> 
>  	mt9p031->clk = devm_clk_get(&client->dev, NULL);
>  	if (IS_ERR(mt9p031->clk))
>  		return PTR_ERR(mt9p031->clk);
> 
> -	clk_set_rate(mt9p031->clk, pdata->ext_freq);
> +	ret = clk_set_rate(mt9p031->clk, pdata->ext_freq);
> +	if (ret < 0)
> +		return ret;
> 
>  	mt9p031->pll.ext_clock = pdata->ext_freq;
>  	mt9p031->pll.pix_clock = pdata->target_freq;
> @@ -286,8 +289,11 @@ static int mt9p031_power_on(struct mt9p031 *mt9p031)
>  		return ret;
> 
>  	/* Emable clock */
> -	if (mt9p031->clk)
> -		clk_prepare_enable(mt9p031->clk);
> +	if (mt9p031->clk) {
> +		ret = clk_prepare_enable(mt9p031->clk);
> +		if (ret)
> +			return ret;

You should call regulator_bulk_disable() in the error path to cancel the 
previous regulator_bulk_enable() call.

> +	}
> 
>  	/* Now RESET_BAR must be high */
>  	if (gpio_is_valid(mt9p031->reset)) {
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/