linux-kernel - Re: [PATCH] x86, cpu hotplug, use cpumask stack safe variant cpumask_var_t in check_irq_vectors_for_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140120085017.GB5243@gchen.bj.intel.com>
Date:	Mon, 20 Jan 2014 03:50:17 -0500
From:	"Chen, Gong" <gong.chen@...ux.intel.com>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Michel Lespinasse <walken@...gle.com>,
	Seiji Aguchi <seiji.aguchi@....com>,
	Yang Zhang <yang.z.zhang@...el.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Janet Morgan <janet.morgan@...el.com>,
	Tony Luck <tony.luck@...el.com>,
	Ruiv Wang <ruiv.wang@...il.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>, x86@...nel.org,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] x86, cpu hotplug, use cpumask stack safe variant
 cpumask_var_t in check_irq_vectors_for_cpu_disable()

On Fri, Jan 17, 2014 at 08:39:21AM -0500, Prarit Bhargava wrote:
[...]
> +
> +	if (!alloc_cpumask_var(&online_new, GFP_KERNEL)){
> +		ret = -ENOMEM;
> +		goto out;
> +	}
> +
> +	if (!alloc_cpumask_var(&affinity_new, GFP_KERNEL)) {
> +		ret = -ENOMEM;
> +		goto free_online_new;
> +	}
>  
This function is protected by stop_machine, which means the interrupts have
been disabled, so GFP_KERNEL is not reliable.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)