linux-kernel - Re: [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52DD52EB.3000308@gmail.com>
Date:	Mon, 20 Jan 2014 10:46:35 -0600
From:	Souvik Banerjee <souvik1997@...il.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110.

I see. Here's the patch with KE_IGNORE instead of KE_KEY. Does it look ok?


This key is reported by the keyboard controller but also generates WMI
events. By adding it to the legacy keymap the WMI messages can be
silenced.
---
 drivers/platform/x86/dell-wmi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/dell-wmi.c
b/drivers/platform/x86/dell-wmi.c
index 60e0900..72f6cc8 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -92,6 +92,9 @@ static const struct key_entry dell_wmi_legacy_keymap[]
__initconst = {
        { KE_IGNORE, 0xe025, { KEY_RESERVED } },
        { KE_IGNORE, 0xe026, { KEY_RESERVED } },

+       /* For laptops like the Dell Inspiron N4110 with a monitor hotkey */
+       { KE_IGNORE, 0xe027, { KEY_SWITCHVIDEOMODE } },
+
        { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
        { KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
        { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
-- 
1.8.5.3



On 01/20/2014 10:37 AM, Matthew Garrett wrote:
> On Mon, Jan 20, 2014 at 10:31:48AM -0600, Souvik Banerjee wrote:
>> I used KE_KEY instead of KE_IGNORE. Should it be changed to KE_IGNORE?
>> On my kernel build with KE_KEY everything works as expected, but I have
>> not tried it with KE_IGNORE.
> 
> KE_KEY means that dell-wmi will report the key. If it's also being 
> reported via the keyboard controller then it should be KE_IGNORE 
> instead.
> 

View attachment "0001-dell-wmi-Add-KEY_SWITCHVIDEOMODE-for-Dell-N4110.patch" of type "text/x-patch" (1080 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)