linux-kernel - Re: [PATCH 0/5] lockdep: (Was: check && lockdep_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140120185401.GA27651@redhat.com>
Date:	Mon, 20 Jan 2014 19:54:01 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: [PATCH 0/5] lockdep: (Was: check && lockdep_no_validate)

On 01/20, Alan Stern wrote:
>
> On Mon, 20 Jan 2014, Oleg Nesterov wrote:
>
> > On 01/17, Alan Stern wrote:
> > >
> > > Also, take a look at commit 356c05d58af0.  It's a similar situation
> > > (not exactly the same).
> >
> > At first glance, can't __ATTR_IGNORE_LOCKDEP() use no_validate too ?
> > (ignoring the fact checkpatch.pl won't be happy). This can simplify
> > the code, it seems.
>
> Well, the macro itself doesn't specify the lockdep class.  That happens
> implicitly in sysfs_get_active(), in the call to rwsem_acquire_read().
> However, it ought to be possible to change the code so that when
> ignore_lockdep(sd) returns nonzero, we end up using no_validate.

sysfs_dirent_init_lockdep() can check ->ignore_lockdep and do
lockdep_set_novalidate_class(). This way sysfs_ignore_lockdep() can
go away.

I guess we could even change __ATTR_IGNORE_LOCKDEP() to initialize
->key = __lockdep_no_validate__ and kill ->ignore_lockdep.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/