| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140121100311.GA8847@dhcp-26-207.brq.redhat.com> Date: Tue, 21 Jan 2014 11:03:12 +0100 From: Alexander Gordeev <agordeev@...hat.com> To: Keith Busch <keith.busch@...el.com> Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Matthew Wilcox <willy@...ux.intel.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-nvme@...ts.infradead.org, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org> Subject: Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak On Mon, Jan 20, 2014 at 03:48:56PM -0700, Keith Busch wrote: > On Mon, 20 Jan 2014, Alexander Gordeev wrote: > >This is an attempt to make handling of admin queue in a > >single scope. This update also fixes a IRQ leak in case > >nvme_setup_io_queues() failed to allocate enough iomem > >and bailed out with -ENOMEM errno. > > This definitely seems to improve the code flow, but this leak was already > fixed in the latest linux-nvme tree with this commit: > > http://git.infradead.org/users/willy/linux-nvme.git/commit/c5dc9192d52a4a3a479f701e97386347d454af84 Oh, that one seems to complicate things even further to me. Whould you consider the revert? Sending an improved version against your tree. -- Regards, Alexander Gordeev agordeev@...hat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists