linux-kernel - Re: [PATCH] drivers/hid/wacom: fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140121202944.GA4554@fedora.fritz.box>
Date:	Tue, 21 Jan 2014 21:29:44 +0100
From:	Rob Schroer <sulamiification@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/hid/wacom: fixed coding style issues

On Tue, Jan 21, 2014 at 12:06:45PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 21, 2014 at 08:51:53PM +0100, Robin Schroer wrote:
> > Fixed some coding style issues regarding spaces before semicolons and
> > closing parenthesis.
> > 
> > Signed-off-by: Robin Schroer <sulamiification@...il.com>
> > ---
> >  drivers/hid/hid-wacom.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> > index 60c75dc..ebcca0d 100644
> > --- a/drivers/hid/hid-wacom.c
> > +++ b/drivers/hid/hid-wacom.c
> > @@ -77,8 +77,8 @@ static void wacom_scramble(__u8 *image)
> >  	__u16 mask;
> >  	__u16 s1;
> >  	__u16 s2;
> > -	__u16 r1 ;
> > -	__u16 r2 ;
> > +	__u16 r1;
> > +	__u16 r2;
> >  	__u16 r;
> >  	__u8 buf[256];
> >  	int i, w, x, y, z;
> > @@ -336,7 +336,7 @@ static void wacom_set_features(struct hid_device *hdev, u8 speed)
> >  
> >  	switch (hdev->product) {
> >  	case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
> > -		rep_data[0] = 0x03 ; rep_data[1] = 0x00;
> > +		rep_data[0] = 0x03; rep_data[1] = 0x00;
> >  		limit = 3;
> >  		do {
> >  			ret = hdev->hid_output_raw_report(hdev, rep_data, 2,
> > @@ -404,7 +404,7 @@ static ssize_t wacom_store_speed(struct device *dev,
> >  	struct hid_device *hdev = container_of(dev, struct hid_device, dev);
> >  	int new_speed;
> >  
> > -	if (sscanf(buf, "%1d", &new_speed ) != 1)
> > +	if (sscanf(buf, "%1d", &new_speed) != 1)
> >  		return -EINVAL;
> 
> Why doesn't it use kstrtoXXX()?
> 
> Thanks.
> 

As far as I can see, kstrtoXXX() might be an alternative, but I was just
fixing coding style issues, no need to break anything IMO.

> >  
> >  	if (new_speed == 0 || new_speed == 1) {
> > -- 
> > 1.8.4.2
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> Dmitry

--
Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/