linux-kernel - Re: [GIT PULL] GPIO bulk changes for v3.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140122080104.3228a7ded7e8174a635d5a94@canb.auug.org.au>
Date:	Wed, 22 Jan 2014 08:01:04 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Lars Poeschel <poeschel@...onage.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [GIT PULL] GPIO bulk changes for v3.14

Hi all,

On Tue, 21 Jan 2014 10:11:39 -0800 Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
> On Tue, Jan 21, 2014 at 12:36 AM, Linus Walleij
> <linus.walleij@...aro.org> wrote:
> >
> > here is the big GPIO pull request for the v3.14 series.
> 
> Ugh. It does not compile for me. The problem seems to be that the
> gpio-mcp23s08.c driver only compiles in OF environments, but isn't
> properly restricted to them:
> 
>   drivers/gpio/gpio-mcp23s08.c: In function ‘mcp23s08_irq_setup’:
>   drivers/gpio/gpio-mcp23s08.c:482:46: error: ‘struct gpio_chip’ has
> no member named ‘of_node’
>     mcp->irq_domain = irq_domain_add_linear(chip->of_node, chip->ngpio,
> 
> and similar other errors.

Yep, reported when it entered linux-next.

> Introduced by commit 4e47f91bf741 ("gpio: mcp23s08: Add irq
> functionality for i2c chips") as far as I can tell.
>
> >  It's big this time but has been brewing in linux-next for
> > some time and it's all good stuff IMO
> 
> The fact that it doesn't even compile makes me doubt your statement
> that it has been in linux-next. It doesn't even pass a basic
> allmodconfig build.

That particular commit was reverted in linux-next when it first turned up
on Monday and again yesterday.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped