linux-kernel - Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140121075738.771d29b3@lilie>
Date:	Tue, 21 Jan 2014 07:57:38 +0100
From:	Philipp Hachtmann <phacht@...ux.vnet.ibm.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	akpm@...ux-foundation.org, hannes@...xchg.org, liuj97@...il.com,
	santosh.shilimkar@...com, grygorii.strashko@...com,
	iamjoonsoo.kim@....com, robin.m.holt@...il.com,
	tangchen@...fujitsu.com, yinghai@...nel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable



Am Mon, 20 Jan 2014 22:16:33 -0800 (PST)
schrieb David Rientjes <rientjes@...gle.com>:

> Not sure why you don't just do a one line patch:
> 
> -	phys_addr_t size;
> +	phys_addr_t size __maybe_unused;
> to fix it.

Just because I did not know that __maybe_unused thing.

Discussion of this fix seems to be obsolete because Andrew already took
the patch int the form he suggested: One #ifdef in the function with a
basic block declaring size once inside.

Regards

Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/