linux-kernel - Re: [BUG] at drivers/md/raid5.c:291! kernel 3.13-rc8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140122115208.6a2b3909@notabene.brown>
Date:	Wed, 22 Jan 2014 11:52:08 +1100
From:	NeilBrown <neilb@...e.de>
To:	Ian Kumlien <ian.kumlien@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>
Subject: Re: [BUG] at drivers/md/raid5.c:291! kernel 3.13-rc8

On Mon, 20 Jan 2014 19:27:18 +0100 Ian Kumlien <ian.kumlien@...il.com> wrote:

> On mån, 2014-01-20 at 14:37 +1100, NeilBrown wrote:
> > 
> > Thanks - that extra info is quite useful.  Knowing that nothing else unusual
> > is happening can be quite valuable (and I don't like to assume).
> > 
> > I haven't found anything that would clearly cause your crash, but I have
> > found something that looks wrong and conceivably could.
> > 
> > Could you please try this patch on top of what you are currently using?  By
> > the look of it you get a crash at least every day, often more often.  So if
> > this produces a day with no crashes, that would be promising.
> > 
> > The important aspect of the patch is that it moves the "atomic_inc" of
> > "sh->count" back under the protection of ->device_lock in the case when some
> > other thread might be using the same 'sh'.
> 
> I have been unable to trip this up, so this was it!
> 
> Tested-by: Ian Kumlien <ian.kumlien@...il.com>
> 
> I hope this hits stable ASAP ;)

I've push it out into my for-next branch.
I'll probably send a pull request to Linus tomorrow.
It has some chance of getting into a -stable branch next week (though I'm not
really sure of the schedule).

Thanks again for testing and reporting!

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)