linux-kernel - Re: [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140122132018.GC1132@krava.brq.redhat.com>
Date:	Wed, 22 Jan 2014 14:20:18 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Rodrigo Campos <rodrigo@...g.com.ar>,
	Andi Kleen <andi@...stfloor.org>, Arun Sharma <asharma@...com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCHSET 00/24] perf tools: Add support to accumulate hist
 periods (v6)

On Tue, Jan 14, 2014 at 02:25:33PM +0900, Namhyung Kim wrote:
> Hello,
> 
> This is a new attempt to implement cumulative hist period report.
> This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely
> rewrote it from scratch.
> 
> This patchset is based on my previous patchset [2] but I think it's
> almost independent so that it can be applied separately.
> 
> Please see the patch 03/24.  I refactored functions that add hist
> entries with struct hist_entry_iter.  While I converted all functions
> carefully, it'd be better anyone can test and confirm that I didn't
> mess up something - especially for branch stack and mem stuff.
> 
> This patchset basically adds period in a sample to every node in the
> callchain.  A hist_entry now has an additional fields to keep the
> cumulative period if --children option is given on perf report.
> 
> I changed the option as a separate --children and added a new
> "Children" column (and renamed the default "Overhead" column into
> "Self").  The output will be sorted by children (cumulative) overhead
> for now.  The reason I changed to the --children is that I still think
> it's much different from other --call-graph options.  The --call-graph
> option will take care of it even with --children option.
> 
> I know that the UI should be changed also to be more flexible as Ingo
> requested, but I'd like to do this first and then move to work on the
> next.  I also added a new config option to enable it by default.
> 
>  * changes in v6:
>   - separate struct hist_iter_ops (Jiri)
>   - check iter->he before calling ->add_entry_cb (Jiri)
>   - fix locking issue on perf top (Jiri)

I have changes on top of this patchset and all looks great, I was
just going throught this again and wanted to send my ack, but it
no longer merges to the acme's perf/core.

Could you please send updated version, and I'll finish the
review.. I promise ;-)

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/