linux-kernel - Re: [PATCH] x86, cpu hotplug, use cpumask stack safe variant cpumask_var_t in check_irq_vectors_for_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140122020049.GA16393@gchen.bj.intel.com>
Date:	Tue, 21 Jan 2014 21:00:49 -0500
From:	"Chen, Gong" <gong.chen@...ux.intel.com>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Michel Lespinasse <walken@...gle.com>,
	Seiji Aguchi <seiji.aguchi@....com>,
	Yang Zhang <yang.z.zhang@...el.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Janet Morgan <janet.morgan@...el.com>,
	Tony Luck <tony.luck@...el.com>,
	Ruiv Wang <ruiv.wang@...il.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>, x86@...nel.org,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] x86, cpu hotplug, use cpumask stack safe variant
 cpumask_var_t in check_irq_vectors_for_cpu_disable() [v2]

On Mon, Jan 20, 2014 at 01:57:58PM -0500, Prarit Bhargava wrote:
> Subject: [PATCH] x86, cpu hotplug, use cpumask stack safe variant
>  cpumask_var_t in check_irq_vectors_for_cpu_disable() [v2]
> 
> kbuild, 0day kernel build service, outputs the warning:
> 
> arch/x86/kernel/irq.c:333:1: warning: the frame size of 2056 bytes
> is larger than 2048 bytes [-Wframe-larger-than=]
> 
> because check_irq_vectors_for_cpu_disable() allocates two cpumasks on the
> stack.  Fix this by using cpumask_var_t, the cpumask stack safe variant.
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Michel Lespinasse <walken@...gle.com>
> Cc: Seiji Aguchi <seiji.aguchi@....com>
> Cc: Yang Zhang <yang.z.zhang@...el.com>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Janet Morgan <janet.morgan@...el.com>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Ruiv Wang <ruiv.wang@...il.com>
> Cc: Gong Chen <gong.chen@...ux.intel.com>
> Cc: H. Peter Anvin <hpa@...ux.intel.com>
> Cc: Gong Chen <gong.chen@...ux.intel.com>
> Cc: x86@...nel.org
> Cc: Fengguang Wu <fengguang.wu@...el.com>
> 
> [v2]: switch from GFP_KERNEL to GFP_ATOMIC

Reviewed-by: Chen, Gong <gong.chen@...ux.intel.com>


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)