[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140122194327.GA2826@redhat.com>
Date: Wed, 22 Jan 2014 20:43:27 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Alex Thorlton <athorlton@....com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
"Kirill A. Shutemov" <kirill@...temov.name>,
linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Rik van Riel <riel@...hat.com>,
Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Andy Lutomirski <luto@...capital.net>,
Al Viro <viro@...iv.linux.org.uk>,
Kees Cook <keescook@...omium.org>,
Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [PATCH 0/2] mm->def_flags cleanups (Was: Change khugepaged to
respect MMF_THP_DISABLE flag)
On 01/22, Oleg Nesterov wrote:
>
> On 01/22, Alex Thorlton wrote:
> > > + case PR_SET_THP_DISABLE:
> > > + case PR_GET_THP_DISABLE:
> > > + down_write(&me->mm->mmap_sem);
> > > + if (option == PR_SET_THP_DISABLE) {
> > > + if (arg2)
> > > + me->mm->def_flags |= VM_NOHUGEPAGE;
> > > + else
> > > + me->mm->def_flags &= ~VM_NOHUGEPAGE;
> > > + } else {
> > > + error = !!(me->mm->flags && VM_NOHUGEPAGE);
> >
> > Should be:
> >
> > error = !!(me->mm->def_flags && VM_NOHUGEPAGE);
>
> No, we need to return 1 if this bit is set ;)
Damn, you are right of course, we need "&". I didn't notice "&&"
in the patch I sent and misunderstood your "&&" above ;) Sorry.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists