linux-kernel - Re: [PATCH-v2 0/3] percpu_ida+Co: Make percpu_ida

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jan 2014 11:58:40 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Kent Overstreet <kmo@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>
Subject: Re: [PATCH-v2 0/3] percpu_ida+Co: Make percpu_ida_alloc accept task
 state bitmask

Hey Jens,

On Mon, 2014-01-20 at 03:44 +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@...ux-iscsi.org>
> 
> Hi Linus,
> 
> Here is the -v2 series for converting percpu_ida_alloc() + consumer
> usage to accept the task state bitmask parameter, w/o the extra
> legacy gfp_t wrapper.
> 
> As requested, the first patch contains only the parameter change
> to percpu_ida_alloc() + existing consumers, and makes no semantic
> or behavior change.  This patch is CC'ed for stable, and will need
> some light massaging to apply back to v3.12.y.
> 

Any objections to the blk-mq changes in patch #1..?  Please ACK.  :)

> The second patch is a blk-mq cleanup to propigate the task state
> bitmask usage up to the blk-mq vs. legacy split in blk_get_request().
> 

How about this one..?  Do you want to pick it up for v3.15, or have it
included in target-pending/for-next now..?

Thanks,

--nab

> The last patch fixes the original iscsi-target session reset bug
> by passing TASK_INTERRUPTIBLE, and adds the signal_pending_state()
> bit required in percpu_ida_alloc() code.  This is also CC'ed for
> v3.12.y.
> 
> CC'ing Ingo + Peter for TASK_RUNNING + prepare_to_wait() bit.
> 
> Thank you,
> 
> --nab
> 
> Kent Overstreet (1):
>   percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask
> 
> Nicholas Bellinger (2):
>   blk-mq: Convert gfp_t parameters to task state bitmask
>   iscsi-target: Fix connection reset hang with percpu_ida_alloc
> 
>  block/blk-core.c                         |    4 +++-
>  block/blk-flush.c                        |    2 +-
>  block/blk-mq-tag.c                       |   14 +++++++-------
>  block/blk-mq-tag.h                       |    2 +-
>  block/blk-mq.c                           |   28 ++++++++++++++--------------
>  drivers/target/iscsi/iscsi_target_util.c |    8 ++++++--
>  drivers/target/tcm_fc/tfc_cmd.c          |    2 +-
>  drivers/vhost/scsi.c                     |    2 +-
>  include/linux/blk-mq.h                   |    4 ++--
>  include/linux/percpu_ida.h               |    3 ++-
>  lib/percpu_ida.c                         |   17 +++++++++++------
>  11 files changed, 49 insertions(+), 37 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/