linux-kernel - Re: [PATCH V5 2/3] mm/memblock: Add support for excluded memory areas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140122124107.ef0ceac16be17c165de56308@linux-foundation.org>
Date:	Wed, 22 Jan 2014 12:41:07 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Philipp Hachtmann <phacht@...ux.vnet.ibm.com>
Cc:	hannes@...xchg.org, liuj97@...il.com, santosh.shilimkar@...com,
	grygorii.strashko@...com, iamjoonsoo.kim@....com,
	robin.m.holt@...il.com, tangchen@...fujitsu.com,
	yinghai@...nel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 2/3] mm/memblock: Add support for excluded memory
 areas

On Wed, 22 Jan 2014 12:18:21 +0100 Philipp Hachtmann <phacht@...ux.vnet.ibm.com> wrote:

> Hi again,
> 
> I'd like to remind that the s390 development relies on this patch
> (and the next one, for cleanliness, of course) being added. It would be
> very good to see it being added to the -mm tree resp. linux-next.
> 

Once the patch has passed review (hopefully by yinghai, who reviews
very well) I'd ask you to include it in the s390 tree which actually
uses it.

Patch 2/3 would benefit from a more complete changelog.  Why does s390
need CONFIG_ARCH_MEMBLOCK_NOMAP?  How is it used and how does it work? 
Do we expect other architectures to use it?  If so, how?  etcetera.

btw, you have a "#ifdef ARCH_MEMBLOCK_NOMAP" in there which should be
CONFIG_ARCH_MEMBLOCK_NOMAP.  I don't see how the code could have
compiled as-is - __next_mapped_mem_range() will be omitted?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/