linux-kernel - Re: [PATCH] gpio: bcm281xx: Fix parameter name for GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbgS3DjG+z79VV_-UUZ+t3DbZM1rxX+pHhuXv6WOxOW6Q@mail.gmail.com>
Date:	Thu, 23 Jan 2014 09:20:19 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Markus Mayer <markus.mayer@...aro.org>
Cc:	Linaro Patches <patches@...aro.org>,
	Linux GPIO List <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tim Kryger <tim.kryger@...aro.org>
Subject: Re: [PATCH] gpio: bcm281xx: Fix parameter name for GPIO_CONTROL macro

On Wed, Jan 22, 2014 at 1:10 AM, Markus Mayer <markus.mayer@...aro.org> wrote:

> The GPIO_CONTROL macro returns the control register offset when given a
> GPIO number.
>
> Update the argument name in the macro to reflect that it takes in a
> GPIO number and not a bank.
>
> Signed-off-by: Markus Mayer <markus.mayer@...aro.org>
> Reviewed-by: Tim Kryger <tim.kryger@...aro.org>
(...)
> +/* There is a GPIO control register for each GPIO */
> +#define GPIO_CONTROL(gpio)                     (0x00000100 + ((gpio) << 2))

Technically I prefer naming this parameter "offset" rather than
"gpio" as it is the offset of a GPIO line in *this* very GPIO
HW block rather than a GPIO number from the global
GPIO number space.

But it's no big deal, so patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/