linux-kernel - Re: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Jan 2014 08:11:02 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Timur Tabi <timur@...i.org>,
	Nicolin Chen <Guangyu.Chen@...escale.com>,
	Takashi Iwai <tiwai@...e.de>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for
 Freeacale SAI

On Thu, Jan 23, 2014 at 5:48 AM, Xiubo Li <Li.Xiubo@...escale.com> wrote:

>  static int fsl_sai_set_dai_sysclk(struct snd_soc_dai *cpu_dai,
>                 int clk_id, unsigned int freq, int dir)
>  {
> -       struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai);
>         int ret;
>
>         if (dir == SND_SOC_CLOCK_IN)
>                 return 0;
>
> -       ret = clk_prepare_enable(sai->clk);
> -       if (ret)
> -               return ret;

The clock related change seems unrelated to the usage of regmap, right?

>  static int fsl_sai_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
>  {
> -       struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai);
>         int ret;
>
> -       ret = clk_prepare_enable(sai->clk);
> -       if (ret)
> -               return ret;

Same here.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/