linux-kernel - Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <52E0F1D7.4030401@samsung.com>
Date:	Thu, 23 Jan 2014 11:41:27 +0100
From:	Sylwester Nawrocki <s.nawrocki@...sung.com>
To:	Naveen Krishna Ch <naveenkrishna.ch@...il.com>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
Cc:	linux-crypto@...r.kernel.org,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>, linux-kernel@...r.kernel.org,
	Vladimir Zapolskiy <vzapolskiy@...il.com>,
	herbert@...dor.apana.org.au, cpgs@...sung.com,
	tomasz.figa@...il.com
Subject: Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

Hi,

On 23/01/14 11:18, Naveen Krishna Ch wrote:
> Hello All,
> 
> On 15 January 2014 14:47, Naveen Krishna Chatradhi
> <ch.naveen@...sung.com> wrote:
>> This patch set adds use of clk_prepare/clk_unprepare as
>> required by generic clock framework.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
>> Reviewed-by: Tomasz Figa <t.figa@...sung.com>
>> ---
>> Changes since v3:
>> None
>>
>>  drivers/crypto/s5p-sss.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
>> index f7c66c7..870e794 100644
>> --- a/drivers/crypto/s5p-sss.c
>> +++ b/drivers/crypto/s5p-sss.c
>> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>>                 return -ENOENT;
>>         }
>>
>> -       clk_enable(pdata->clk);
>> +       clk_prepare_enable(pdata->clk);

How about properly checking the return value ?

--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/