linux-kernel - Re: randconfig build error with next-20140122, in arch/x86/kernel/devicetree.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP=VYLq_rhAUqyfPAPYTwAH5zjR4OtpULGPh6dBQJDbGtG8ZcA@mail.gmail.com>
Date:	Wed, 22 Jan 2014 19:26:12 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Jim Davis <jim.epost@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>, mingo@...hat.com,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: randconfig build error with next-20140122, in arch/x86/kernel/devicetree.c

On Wed, Jan 22, 2014 at 12:06 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> On 01/22/2014 08:34 AM, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> warning: (X86_INTEL_MID) selects INTEL_SCU_IPC which has unmet direct
>> dependencies (X86 && X86_PLATFORM_DEVICES && X86_INTEL_MID)
>> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
>> which has unmet direct dependencies (USB_SUPPORT && USB && PM_RUNTIME)
>> warning: (X86_INTEL_MID) selects INTEL_SCU_IPC which has unmet direct
>> dependencies (X86 && X86_PLATFORM_DEVICES && X86_INTEL_MID)
>> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
>> which has unmet direct dependencies (USB_SUPPORT && USB && PM_RUNTIME)
>>
>> arch/x86/kernel/devicetree.c:67:1: warning: data definition has no
>> type or storage class [enabled by default]
>>  module_init(add_bus_probe);
>>  ^
>
> For linux-next, devicetree.c needs to #include <linux/module.h>.
> For mainline, it would have needed to #include <linux/init.h>.
> However, it does neither of those.

Thanks guys; I've already queued a fix for this.

http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/commit/?id=3d83b6b84210066f0886b0916136fa49ca61704d

Paul.
--

>
> See Documentation/SubmitChecklist #1:
>
> 1: If you use a facility then #include the file that defines/declares
>    that facility.  Don't depend on other header files pulling in ones
>    that you use.http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/commit/?id=3d83b6b84210066f0886b0916136fa49ca61704d
>
>
>> arch/x86/kernel/devicetree.c:67:1: error: type defaults to ‘int’ in
>> declaration of ‘module_init’ [-Werror=implicit-int]
>> arch/x86/kernel/devicetree.c:67:1: warning: parameter names (without
>> types) in function declaration [enabled by default]
>> arch/x86/kernel/devicetree.c:60:19: warning: ‘add_bus_probe’ defined
>> but not used [-Wunused-function]
>>  static int __init add_bus_probe(void)
>>                    ^
>> cc1: some warnings being treated as errors
>> make[2]: *** [arch/x86/kernel/devicetree.o] Error 1
>>
>
>
> --
> ~Randy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/