linux-kernel - Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140123150524.GH29955@cumulusnetworks.com>
Date:	Thu, 23 Jan 2014 07:05:24 -0800
From:	Curt Brune <curt@...ulusnetworks.com>
To:	Laszlo Papp <lpapp@....org>
Cc:	Thomas De Schampheleire <patrickdepinguin@...il.com>,
	gregkh@...uxfoundation.org,
	Shrijeet Mukherjee <shm@...ulusnetworks.com>,
	wolfram@...-dreams.de, linux-i2c@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware
 class

On Thu Jan 23 07:44, Laszlo Papp wrote:
> On Wed, Jan 22, 2014 at 5:23 PM, Curt Brune <curt@...ulusnetworks.com> wrote:
> > During device instantiation have the at24 driver add the new device to
> > the eeprom_dev hardware class.  The functionality is enabled by
> > CONFIG_EEPROM_CLASS.
[snip]
> >  static void __exit at24_exit(void)
> >  {
> >         i2c_del_driver(&at24_driver);
> >  }
> >  module_exit(at24_exit);
> 
> Couldn't you use module_i2c_driver() instead of this?

I'm not sure what you mean.

Do you mean should the class registration/unregistration be put in
module_i2c_driver()?  That would not work as not all i2c devices are
eeproms.

> 
> >  MODULE_DESCRIPTION("Driver for most I2C EEPROMs");
> >  MODULE_AUTHOR("David Brownell and Wolfram Sang");
> 
> I would personally put your name in here if I were you, otherwise
> David and Wolfram might get contacted by some people instead of you
> (at least based on this).

Hmmm.   I don't know.  I didn't change the driver very much, just
added about 10 lines to a perfectly fine driver.  git-blame would
point right at me for anything to do with this patch.

> 
> PS.: Fixing the broken i2c mailing list typo, and updating Wolfram's
> address from the broken (obsolete?) version.

Thanks for fixing that.

Cheers,
Curt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/