linux-kernel - Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Jan 2014 11:09:44 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Valentina Manea <valentina.manea.m@...il.com>
Cc:	anthony.foiani@...il.com, devel@...verdev.osuosl.org,
	navinp@...c.in, linux-usb@...r.kernel.org, ly80toro@....cs.fau.de,
	josh@...htriplett.org, linux-kernel@...r.kernel.org,
	firefly@...ts.rosedu.org, tulinizer@...il.com,
	stern@...land.harvard.edu, yacine.belkadi.1@...il.com,
	ke42caxa@....cs.fau.de
Subject: Re: [PATCH] staging: usbip: convert usbip-host driver to
 usb_device_driver

On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote:
> This driver was previously an interface driver. Since USB/IP
> exports a whole device, not just an interface, it would make
> sense to be a device driver.
> 
> This patch also modifies the way userspace sees and uses a
> shared device - dealing with interfaces is no longer required.

In what way is this modified?  What is now different?

> --- a/drivers/usb/core/generic.c
> +++ b/drivers/usb/core/generic.c
> @@ -155,6 +155,7 @@ int usb_choose_configuration(struct usb_device *udev)
>  	}
>  	return i;
>  }
> +EXPORT_SYMBOL(usb_choose_configuration);
>  
>  static int generic_probe(struct usb_device *udev)
>  {
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index bb31597..fb0a555 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1921,6 +1921,7 @@ free_interfaces:
>  	usb_autosuspend_device(dev);
>  	return 0;
>  }
> +EXPORT_SYMBOL(usb_set_configuration);
>  
>  static LIST_HEAD(set_config_list);
>  static DEFINE_SPINLOCK(set_config_lock);

Please make both of these EXPORT_SYMBOL_GPL(), like the rest of the USB
symbols are.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/