linux-kernel - Re: [PATCH Resend 7/8] ASoC: add snd_soc_of_parse_audio_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140123193945.GH11727@sirena.org.uk>
Date:	Thu, 23 Jan 2014 19:39:45 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	lgirdwood@...il.com, shawn.guo@...aro.org,
	kuninori.morimoto.gx@...esas.com, moinejf@...e.fr,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH Resend 7/8] ASoC: add
 snd_soc_of_parse_audio_simple_widgets for DeviceTree

On Thu, Jan 23, 2014 at 01:02:49PM +0800, Xiubo Li wrote:

> +static struct snd_soc_dapm_widget simple_widgets[] = {
> +	SND_SOC_DAPM_MIC("Mic", NULL),
> +	SND_SOC_DAPM_LINE("Line", NULL),
> +	SND_SOC_DAPM_HP("Hp", NULL),
> +	SND_SOC_DAPM_SPK("Spk", NULL),
> +};

Does this mean we're restricted to a particular set of names?  That
seems sad and won't work if there's a desire for more than one of a
given widget - the main use case I can see is multiple microphones with
separate microphone biases.  How about having some templates that we
copy and then replace the name with the one the user supplied?

> +	if (cnt <= 0) {
> +		dev_err(card->dev,
> +			"ASoC: Property '%s' does not exist or "
> +			"length is zero\n", propname);

Don't split error messages over lines, this makes it harder to grep for
them.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)