linux-kernel - [PATCH 3/4] mtd: block2mtd: check device size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140123205331.03314c6f82f24a6bb4b8ef53@skynet.be>
Date:	Thu, 23 Jan 2014 20:53:31 +0100
From:	Fabian Frederick <fabf@...net.be>
To:	linux-mtd@...ts.infradead.org
Cc:	akpm@...ux-foundation.org, rdunlap@...radead.org,
	joern@...ybastard.org, linux-kernel@...r.kernel.org,
	ezequiel.garcia@...e-electrons.com
Subject: [PATCH 3/4] mtd: block2mtd: check device size

fixme applied : check device size is a multiple of erasesize.

Signed-off-by: Fabian Frederick <fabf@...net.be>
---
 drivers/mtd/devices/block2mtd.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index 8071596..f0fd4fc 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -209,7 +209,6 @@ static void block2mtd_free_device(struct block2mtd_dev *dev)
 }
 
 
-/* FIXME: ensure that mtd->size % erase_size == 0 */
 static struct block2mtd_dev *add_device(char *devname, int erase_size)
 {
 	const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
@@ -250,6 +249,11 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
 		goto devinit_err1;
 	}
 
+	if ((long)dev->blkdev->bd_inode->i_size % erase_size) {
+		pr_err("erasesize muse be a divisor of device size\n");
+		goto devinit_err1;
+	}
+
 	mutex_init(&dev->write_mutex);
 
 	/* Setup the MTD structure */
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/