| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1390508811-3755-1-git-send-email-paul.gortmaker@windriver.com> Date: Thu, 23 Jan 2014 15:26:51 -0500 From: Paul Gortmaker <paul.gortmaker@...driver.com> To: <linux-kernel@...r.kernel.org> CC: Paul Gortmaker <paul.gortmaker@...driver.com>, Chris Zankel <chris@...kel.net>, Max Filippov <jcmvbkbc@...il.com>, Thomas Meyer <thomas@...3r.de>, <linux-xtensa@...ux-xtensa.org> Subject: [PATCH] xtensa: don't use module_init for non-modular core network.c code The network.c code is always built in. It will never be modular, so using module_init as an alias for __initcall is rather misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Direct use of __initcall is discouraged, vs prioritized ones. Use of device_initcall is consistent with what __initcall maps onto, and hence does not change the init order, making the impact of this change zero. Should someone with real hardware for boot testing want to change it later to arch_initcall or something different, they can do that at a later date. Cc: Chris Zankel <chris@...kel.net> Cc: Max Filippov <jcmvbkbc@...il.com> Cc: Thomas Meyer <thomas@...3r.de> Cc: linux-xtensa@...ux-xtensa.org Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> --- [patch will be added to init cleanup series: http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/ ] arch/xtensa/platforms/iss/network.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c index d05f8feeb8d7..32b413b21483 100644 --- a/arch/xtensa/platforms/iss/network.c +++ b/arch/xtensa/platforms/iss/network.c @@ -680,6 +680,4 @@ static int iss_net_init(void) return 1; } - -module_init(iss_net_init); - +device_initcall(iss_net_init); -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists