linux-kernel - Re: Re: [PATCH -tip 4/8] perf-probe: Use the actual address instead of the symbol name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52E1C6AC.4000608@hitachi.com>
Date:	Fri, 24 Jan 2014 10:49:32 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	David Ahern <dsahern@...il.com>, linux-kernel@...r.kernel.org,
	Oleg Nesterov <oleg@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	"David A. Long" <dave.long@...aro.org>,
	yrl.pp-manager.tt@...achi.com, Namhyung Kim <namhyung@...nel.org>
Subject: Re: Re: [PATCH -tip 4/8] perf-probe: Use the actual address instead
 of the symbol name

(2014/01/24 1:12), Steven Rostedt wrote:
> On Thu, 23 Jan 2014 11:52:11 -0300
> Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:
> 
>> Em Thu, Jan 23, 2014 at 02:29:55AM +0000, Masami Hiramatsu escreveu:
>>> Since several local symbols can have same name (e.g. t_show),
>>> we need to use the actual address instead of symbol name for
>>> those points. Note that this works only with debuginfo.
>>>
>>> E.g. without this change;
>>> ----
>>
>> Please use spaces after dashed lines, this is even as (or more)
>> important as prefixing # lines, as this makes everything after the ---
>> line and the patch itself to be ignored.
>>

Oops, I thought that "----" was safe...

> You recommend after? I found adding a single space before the dashes
> better, as that way I know I added one and didn't forget to.

OK, I'll add at least one space before dashes.

BTW, should "#" have two spaces instead of one?

Thank you

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/