linux-kernel - Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zjmleoxp.wl%kuninori.morimoto.gx@gmail.com>
Date:	Fri, 24 Jan 2014 00:58:46 -0800 (PST)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	Morimoto <kuninori.morimoto.gx@...esas.com>,
	Linux-SH <linux-sh@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver


Hi Geert

> > This driver is called from shdma-base.c.
> > And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style.
> >
> >  1) this "slave_id" came from shdma_ops::set_slave
> >     and, it is using "int"
> >  2) above drivers have same xxx_find_slave(),
> >     they are using "int".
> >     (this driver is based on that)
> >
> > What should I do ?
> 
> OK, then you should keep using int, and change the test to:
> 
>     if (slave_id < 0 || slave_id >= AUDMAPP_SLAVE_NUMBER)

I see
Thank you

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/