linux-kernel - Re: [mac80211] BUG: unable to handle kernel paging request at 6b6b6b8f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140124123526.GA28678@localhost>
Date:	Fri, 24 Jan 2014 20:35:26 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [mac80211] BUG: unable to handle kernel paging request at
 6b6b6b8f

On Fri, Jan 24, 2014 at 01:17:50PM +0100, Johannes Berg wrote:
> On Fri, 2014-01-24 at 20:08 +0800, Fengguang Wu wrote:
> > Hi Johannes,
> > 
> > The BUG does not show up in linux-next 20140124, is it fixed now?
> 
> It isn't in linux-next yet I believe (mac80211-next isn't in there), but
> yeah, I fixed it already, ran into it myself yesterday. Hope it didn't
> cause you too much trouble.

That's great, you are quick hand! It's not problem at all for me. :)

Thanks,
Fengguang

> The problem was that I misplaced some code
> because I didn't notice that the if () condition (see below) had no
> braces.
> 
> I replaced that commit with
> commit 091a69f86862454c282d4a64c9d66074e60514ea
> Author: Johannes Berg <johannes.berg@...el.com>
> Date:   Wed Jan 22 10:36:59 2014 +0100
> 
>     mac80211: remove module handling from rate control ops
> 
> which now contains this change
> 
>         list_for_each_entry(alg, &rate_ctrl_algs, list) {
> -               if (!strcmp(alg->ops->name, name))
> -                       if (try_module_get(alg->ops->module)) {
> -                               ops = alg->ops;
> -                               break;
> -                       }
> +               if (!strcmp(alg->ops->name, name)) {
> +                       ops = alg->ops;
> +                       break;
> +               }
>         }
> 
> (note the new set of braces added around the content of the strcmp if)
> 
> Sorry!
> 
> johannes
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/