linux-kernel - Re: [PATCH] staging/usbip: Add missing speeds to userspace speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Jan 2014 10:38:32 -0700
From:	Shuah Khan <shuah.kh@...sung.com>
To:	Thomas Pugliese <thomas.pugliese@...il.com>
Cc:	gregkh@...uxfoundation.org, ly80toro@....cs.fau.de,
	alan@...ux.intel.com, linux-usb@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	shuahkhan@...il.com, Shuah Khan <shuah.kh@...sung.com>
Subject: Re: [PATCH] staging/usbip: Add missing speeds to userspace
 speed_strings array

On 01/24/2014 10:31 AM, Thomas Pugliese wrote:
>
>
> On Fri, 24 Jan 2014, Shuah Khan wrote:
>
>> On 01/24/2014 10:08 AM, Thomas Pugliese wrote:
>>>
>>>
>>> On Wed, 22 Jan 2014, Shuah Khan wrote:
>>>
>>>> Add speed strings for usb wireless and 3.0 to speed_strings array.
>>>>
>>>> Signed-off-by: Shuah Khan <shuah.kh@...sung.com>
>>>> ---
>>>>    drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> index 66f03cc..8cb4fcc 100644
>>>> --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = {
>>>>    	{ USB_SPEED_LOW,  "1.5", "Low Speed(1.5Mbps)"  },
>>>>    	{ USB_SPEED_FULL, "12",  "Full Speed(12Mbps)" },
>>>>    	{ USB_SPEED_HIGH, "480", "High Speed(480Mbps)" },
>>>> +	{ USB_SPEED_WIRELESS, "2.5", "Wireless"},
>>>> +	{ USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" },
>>>>    	{ 0, NULL, NULL }
>>>>    };
>>>>
>>>> --
>>>
>>> Wireless USB supports variable speeds from 53.3Mbps to 480Mbps.  I'm not
>>> sure how you want to represent that but "2.5" doesn't seem to apply.
>>>
>>
>> Would "variable" be better suited in this case?
>>
>
> Sure.  You could also use something like "53.3-480" since that would more
> closely match the other entires which are numerical values in Mbps units.
>
> Thomas
>

"53.3-480" sounds good. I will send v2 with that change. Thanks for the 
review.

-- Shuah

-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@...sung.com | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/