linux-kernel - Re: Panic on 8-node system in memblock_virt_alloc_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Jan 2014 10:51:40 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Dave Hansen <dave.hansen@...el.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Panic on 8-node system in memblock_virt_alloc_try_nid()

On Fri, Jan 24, 2014 at 10:42 AM, Dave Hansen <dave.hansen@...el.com> wrote:
> On 01/24/2014 10:24 AM, Yinghai Lu wrote:
>> On Fri, Jan 24, 2014 at 10:19 AM, Dave Hansen <dave.hansen@...el.com> wrote:
>>> FWIW, I did turn of memblock=debug.  It eventually booted, but
>>> slooooooooooowly.
>>
>> then that is not a problem, as you are using 4k page mapping only.
>> and that printout is too spew...
>
> This means that, essentially, memblock=debug and
> KMEMCHECK/DEBUG_PAGEALLOC can't be used together.  That's a shame
> because my DEBUG_PAGEALLOC config *broke* this code a few months ago,
> right?  Oh well.

should only be broken when MOVABLE_NODE is enabled on big system.

>
>>> How many problems in this code are we tracking, btw?  This is at least
>>> 3, right?
>>
>> two problems:
>> 1. big numa system.
>> 2. Andrew's system with swiotlb.
>
> Can I ask politely for some more caution on your part in this area?
> This is two consecutive kernels where this code has broken my system.

I agree, the code get messy as now we have top_down and bottom up
mapping for different configuration.

I already tried hard to make parsing srat early solution instead that split.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/