linux-kernel - Re: [PATCH 3/3] dynamic_debug: replace obselete simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52E2C71A.7040002@akamai.com>
Date:	Fri, 24 Jan 2014 15:03:38 -0500
From:	Jason Baron <jbaron@...mai.com>
To:	Andrey Ryabinin <a.ryabinin@...sung.com>,
	gregkh@...uxfoundation.org
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] dynamic_debug: replace obselete simple_strtoul()
 with kstrtouint()

Hi,

I think we want some sort of commit message for this patch. But they
all look good to me and they tested fine.

Acked-by: Jason Baron <jbaron@...mai.com>

Greg, Can you pick up this series?

Thanks,

-Jason

On 01/23/2014 08:20 AM, Andrey Ryabinin wrote:
> Signed-off-by: Andrey Ryabinin <a.ryabinin@...sung.com>
> ---
>  lib/dynamic_debug.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index e488d9a..7288e38 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -268,14 +268,12 @@ static int ddebug_tokenize(char *buf, char *words[], int maxwords)
>   */
>  static inline int parse_lineno(const char *str, unsigned int *val)
>  {
> -	char *end = NULL;
>  	BUG_ON(str == NULL);
>  	if (*str == '\0') {
>  		*val = 0;
>  		return 0;
>  	}
> -	*val = simple_strtoul(str, &end, 10);
> -	if (end == NULL || end == str || *end != '\0') {
> +	if (kstrtouint(str, 10, val) < 0) {
>  		pr_err("bad line-number: %s\n", str);
>  		return -EINVAL;
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/