linux-kernel - Re: [PATCH] drivers: staging: Mark functions as static and remove unused function in bpctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMpEsFFkb13RuiJMxB80MS6dEmzJ4XJVTTOev1veSvxVpyY0zw@mail.gmail.com>
Date:	Fri, 24 Jan 2014 13:52:00 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Linux-Kernel <linux-kernel@...r.kernel.org>,
	driverdev <devel@...verdev.osuosl.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Josh Triplett <josh@...htriplett.org>,
	Tülin İzer <tulinizer@...il.com>,
	Michael Banken <michael.banken@...he.stud.uni-erlangen.de>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] drivers: staging: Mark functions as static and remove
 unused function in bpctl_mod.c

On Fri, Jan 24, 2014 at 1:34 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Fri, Jan 24, 2014 at 04:14:00AM +0530, Rashika Kheria wrote:
>> Mark functions as static in bpctl_mod.c because they are not used
>> outside this file. Remove unused function from bpctl_mod.c.
>>
>> This also eliminates the following warnings from bpctl_mod.c:
>> drivers/staging/silicom/bpctl_mod.c:1507:6: warning: no previous prototype for ‘send_bypass_clear_pulse’ [-Wmissing-prototypes]
>> drivers/staging/silicom/bpctl_mod.c:1762:5: warning: no previous prototype for ‘cmnd_on’ [-Wmissing-prototypes]
>
> Don't do these massive text blocks.  Just put one or two of the errors
> so we get the idea.
>

Sure.

Thanks,
-- 
Rashika Kheria
B.Tech CSE
IIIT Hyderabad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/