linux-kernel - Re: [PATCH] usb: phy: Quiet unable to find transceiver message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA7iFPHXz1Mn+Ri07Ajr1FYpm1ubVoq-twrFC1Rbu=p_HA@mail.gmail.com>
Date:	Sat, 25 Jan 2014 15:24:55 -0500
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	valentine.barshak@...entembedded.com
Subject: Re: [PATCH] usb: phy: Quiet unable to find transceiver message

On Sat, Jan 25, 2014 at 10:37 AM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Sat, 25 Jan 2014, Josh Boyer wrote:
>
>> commit 1ae5799ef6317 ("usb: hcd: Initialize USB phy if needed") allows
>> the USB layer to initialize external PHYs if needed.  However, a PHY is
>> not needed in all cases.  The usb_get_phy_device function will print
>> an error message, "unable to find transceiver" but everything still
>> functions normally.
>>
>> Drop the severity of this message to pr_debug.
>>
>> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>
>> ---
>>  drivers/usb/phy/phy.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
>> index e6f61e4..c7fe880 100644
>> --- a/drivers/usb/phy/phy.c
>> +++ b/drivers/usb/phy/phy.c
>> @@ -228,7 +228,7 @@ struct usb_phy *usb_get_phy_dev(struct device *dev, u8 index)
>>
>>       phy = __usb_find_phy_dev(dev, &phy_bind_list, index);
>>       if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) {
>> -             pr_err("unable to find transceiver\n");
>> +             pr_debug("unable to find transceiver\n");
>>               goto err0;
>>       }
>
> Wouldn't it make more sense to change this to dev_debug?  As it stands,
> the user has no idea which device is lacking a transceiver.

Quite possibly, yes.  I'm not overly familiar with the subsystem and
was just writing up what Felipe suggested.

> (The same is probably true for other log messages in this source file.)

I don't disagree, but I'd rather someone with more experience in the
USB subsystem do that kind of broader audit/change.  I'd be happy to
test.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/