linux-kernel - Re: [RFC PATCH v5 1/2] sysctl: Make neg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140125085836.GB16070@gmail.com>
Date:	Sat, 25 Jan 2014 09:58:36 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Aaron Tomlin <atomlin@...hat.com>
Cc:	linux-kernel@...r.kernel.org, rientjes@...gle.com,
	mingo@...hat.com, oleg@...hat.com, riel@...hat.com,
	akpm@...ux-foundation.org
Subject: Re: [RFC PATCH v5 1/2] sysctl: Make neg_one a standard constraint


* Ingo Molnar <mingo@...nel.org> wrote:

> 
> * Aaron Tomlin <atomlin@...hat.com> wrote:
> 
> > Add neg_one to the list of standard constraints.
> > 
> > Signed-off-by: Aaron Tomlin <atomlin@...hat.com>
> > Acked-by: Rik van Riel <riel@...hat.com>
> > Acked-by: David Rientjes <rientjes@...gle.com>
> > ---
> >  kernel/sysctl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > index 34a6047..dd531a6 100644
> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;
> >  static int sixty = 60;
> >  #endif
> >  
> > +static int neg_one = -1;
> >  static int zero;
> >  static int __maybe_unused one = 1;
> >  static int __maybe_unused two = 2;
> 
> So what happens if CONFIG_DETECT_HUNG_TASK is not defined and 
> neg_one is unused? The compiler generates an unused variable 
> warning.

Note, I fixed this up in your patch, no need to resend.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/