linux-kernel - Re: [PATCH -next] isp1704_charger: remove useless check in isp1704_charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 25 Jan 2014 15:22:24 +0400
From:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	anton@...msg.org, dwmw2@...radead.org, grant.likely@...aro.org,
	robh+dt@...nel.org, yongjun_wei@...ndmicro.com.cn,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] isp1704_charger: remove useless check in
 isp1704_charger_probe()

On Tue, Jan 07, 2014 at 09:12:29PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Neither devm_usb_get_phy_by_phandle() nor devm_usb_get_phy() can
> return a NULL result, so remove the useless !isp->phy check.

Thank you, applying.

> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/power/isp1704_charger.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
> index 80edb7d..0b4cf9d 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -444,8 +444,6 @@ static int isp1704_charger_probe(struct platform_device *pdev)
>  		ret = PTR_ERR(isp->phy);
>  		goto fail0;
>  	}
> -	if (!isp->phy)
> -		goto fail0;
>  
>  	isp->dev = &pdev->dev;
>  	platform_set_drvdata(pdev, isp);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/