linux-kernel - Re: [PATCH 0/8] perf tools: kaslr fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140126184310.GB1126@krava.brq.redhat.com>
Date:	Sun, 26 Jan 2014 19:43:10 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 0/8] perf tools: kaslr fixes

On Fri, Jan 24, 2014 at 05:10:10PM +0200, Adrian Hunter wrote:
> Hi
> 
> Here are some patches that improve perf tools
> handling of relocation.
> 
> This has become an issue as mentioned in this
> thread:
> 
> 	http://marc.info/?l=linux-kernel&m=139030004314756
> 
> 
> It looks like the changes I made to vmlinux and
> module mapping to allow object code to be read
> broke the symbol annotation for relocated kernels.
> The first patch fixes that.
> 
> There were some other issues though:
> 	- ref_reloc_sym was not always set up
> 	- mustn't use kcore if the kernel has moved
> 	- kallsyms is not unique for a given
> 	buildid
> 
> These things need more testing but I thought it was
> worth getting comments now.
> 
> 
> Adrian Hunter (8):
>       perf tools: Fix symbol annotation for relocated kernel
>       perf tools: Add kallsyms__get_function_start()
>       perf tools: Add machine__get_kallsyms_filename()
>       perf tools: Set up ref_reloc_sym in machine__create_kernel_maps()
>       perf report: Get ref_reloc_sym from kernel map
>       perf tools: Prevent the use of kcore if the kernel has moved
>       perf tools: test does not need to set up ref_reloc_sym
>       perf tools: Adjust kallsyms for relocated kernel

cannot say much for the code changes (look ok ;-) ), but
it fixed the issue for me

Tested-by: Jiri Olsa <jolsa@...hat.com>

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/