[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <52E59B6E.6080701@nod.at>
Date: Mon, 27 Jan 2014 00:34:06 +0100
From: Richard Weinberger <richard@....at>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC: rui.zhang@...el.com, eduardo.valentin@...com,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
horms@...ge.net.au, laurent.pinchart+renesas@...asonboard.com
Subject: Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
Am 27.01.2014 00:30, schrieb Laurent Pinchart:
> Hi Richard,
>
> Thank you for the patch.
>
> On Saturday 25 January 2014 23:29:14 Richard Weinberger wrote:
>> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with
>> COMPILE_TEST) broke build on archs wihout io memory.
>>
>> On archs like S390 or um this driver cannot build nor work.
>> Make it depend on HAS_IOMEM to bypass build failures.
>>
>> drivers/thermal/rcar_thermal.c:404: undefined reference to
>> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined
>> reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <richard@....at>
>> ---
>> drivers/thermal/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 35c0664..88efa8f 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
>> config RCAR_THERMAL
>> tristate "Renesas R-Car thermal driver"
>> depends on ARCH_SHMOBILE || COMPILE_TEST
>> + depends on HAS_IO_MEM
>
> Shouldn't that be HAS_IOMEM ?
m(
Of course...will resend tomorrow.
>> help
>> Enable this to plug the R-Car thermal sensor driver into the Linux
>> thermal framework.
>
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists