linux-kernel - patch "[SCSI] Fix out of spec CD-ROM problem with media change" will cause usb disk resume fail.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <C3050A4DBA34F345975765E43127F10F25E49B33@SZXEMA512-MBX.china.huawei.com>
Date:	Sun, 26 Jan 2014 08:03:09 +0000
From:	Caizhiyong <caizhiyong@...ilicon.com>
To:	TARUISI Hiroaki <taruishi.hiroak@...fujitsu.com>,
	James Bottomley <JBottomley@...allels.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wanglin (Albert)" <albert.wanglin@...ilicon.com>,
	"Liuhui (B)" <liuhui88.liuhui@...ilicon.com>,
	"Ouyangshiting (Tim)" <tim.ouyang@...ilicon.com>,
	Wanting <wanting@...ilicon.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: patch "[SCSI] Fix out of spec CD-ROM problem with media change"
 will cause usb  disk resume fail.

>    [SCSI] Fix out of spec CD-ROM problem with media change
>
>    Some CD-ROMs fail to report a media change correctly.  The specific
>    one for this patch simply fails to respond to commands, then gives a
>    UNIT ATTENTION after being reset which returns ASC/ASCQ 28/00.  This
>    is out of spec behaviour, but add a check in the eat CC/UA on reset
>    path to catch this case so the CD-ROM will function somewhat properly.
>
>    [jejb: fixed up white space and accepted without signoff]
>    Signed-off-by: James Bottomley <JBottomley@...allels.com>
>
>diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
>index a4b9cdb..dc6131e 100644
>--- a/drivers/scsi/scsi_error.c
>+++ b/drivers/scsi/scsi_error.c
>@@ -293,8 +293,16 @@ static int scsi_check_sense(struct scsi_cmnd *scmd)
>                 * so that we can deal with it there.
>                 */
>                if (scmd->device->expecting_cc_ua) {
>-                       scmd->device->expecting_cc_ua = 0;
>-                       return NEEDS_RETRY;
>+                       /*
>+                        * Because some device does not queue unit
>+                        * attentions correctly, we carefully check
>+                        * additional sense code and qualifier so as
>+                        * not to squash media change unit attention.
>+                        */
>+                       if (sshdr.asc != 0x28 || sshdr.ascq != 0x00) {
>+                               scmd->device->expecting_cc_ua = 0;
>+                               return NEEDS_RETRY;
>+                       }
>                }

Consider this scene:

1. Insert usb disk.
2. System suspend, usb controller power off.
3. System resume, usb controller power on, reset the usb disk. When read/write usb disk, it will pass up "media changed" status to scsi layer.
   this time need NEEDS_RETRY cmd，but this patch filter NEEDS_RETRY cmd, block layer report "IO ERRROR".


Looking forward to your feedback.
Best regards.
Cai Zhiyong.
http://www.huawei.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/